Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy: Fix some warnings. #315

Merged
merged 10 commits into from
May 5, 2024
Merged

Conversation

waywardmonkeys
Copy link
Collaborator

No description provided.

@waywardmonkeys waywardmonkeys changed the title clippy: Fix needless_borrowed_reference warnings. clippy: Fix some warnings. Jul 23, 2023
Copy link
Collaborator

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the trailing full-stops in the commit messages¹ this LGTM.

¹ My day job includes typesetting and sometimes copy-editing.

@alerque
Copy link
Collaborator

alerque commented Mar 9, 2024

It looks like Clippy has a new lint since you setup this PR. The get_first lint is valid for Rust 1.63.0 and up so this does not affect our MSRV.

@waywardmonkeys waywardmonkeys force-pushed the clippy-fixes branch 2 times, most recently from 1238679 to f6020c6 Compare May 3, 2024 05:25
@waywardmonkeys
Copy link
Collaborator Author

rebased forward, edited commit messages some, fixed cargo fmt, added fixes for the semicolons stuff.

@alerque alerque merged commit 5153a7a into projectfluent:main May 5, 2024
5 checks passed
@waywardmonkeys waywardmonkeys deleted the clippy-fixes branch May 6, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants